-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update otel version to match Kong Gateway version #13325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice yeah this LGTM!
To make this fix work, we're adding a hack that prevents the normal plugin compatibility checks to be done for the opentelemetry plugin if the version of the plugin reported by the DP is 0.1.0.
9b8deb8
to
c7e99ba
Compare
@Hayk-S Can you please test this change? |
@hanshuebner our e2e OTEL tests pass against this image: https://github.com/Kong/kong/actions/runs/9764898907/job/26954598846#step:7:58 |
Can you also test whether green/blue upgrades still work? The change really only does something in mixed version hybrid mode situations. |
@hanshuebner I ran our Plugin CP<>DP Version Compatibility tests with CP (including this fix) and DP (3.7.1) and these tests also passed for the OTEL plugin, no configuration issues were noticed https://github.com/Kong/kong-test-automation/actions/runs/9767950727/job/26964387736#step:7:184 |
Hi @hanshuebner , shall we cherry-pick this PR to EE? |
@AndyZhang0707 EE does not have the issue, so cherry picking is not needed. |
Summary
To make this fix work, we're adding a hack that prevents the normal plugin compatibility checks to be done for the opentelemetry plugin if the version of the plugin reported by the DP is 0.1.0.
Tested using https://github.com/Kong/otel-hybrid-mode-hack-test
Cherry-pick to kong-ee is not needed as the problem does not exist there, the plugin's version is already in sync with Kong Gateway itself.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-1410